ash/wm/overview/window_selector_window.cc - Issue 331643004: Update the window labels if they change in overview mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/window_selector_window.cc

Issue 331643004: Update the window labels if they change in overview mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Sky's comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/overview/window_selector_unittest.cc ('K') | « ash/wm/overview/window_selector_unittest.cc ('k') | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/overview/window_selector_window.cc

diff --git a/ash/wm/overview/window_selector_window.cc b/ash/wm/overview/window_selector_window.cc

index ae276b63d95d9f2935779ec187b10154e8e2bff0..ed06e8e26d0b447252288a2227d2def27d661bee 100644

--- a/ash/wm/overview/window_selector_window.cc

+++ b/ash/wm/overview/window_selector_window.cc

@@ -21,9 +21,12 @@ namespace ash {

WindowSelectorWindow::WindowSelectorWindow(aura::Window* window)

: transform_window_(window) {

+ window->AddObserver(this);

}

WindowSelectorWindow::~WindowSelectorWindow() {

+ if (transform_window_.window())

+ transform_window_.window()->RemoveObserver(this);

}

aura::Window* WindowSelectorWindow::GetRootWindow() {

@@ -48,6 +51,7 @@ aura::Window* WindowSelectorWindow::SelectionWindow() {

void WindowSelectorWindow::RemoveWindow(const aura::Window* window) {

DCHECK_EQ(transform_window_.window(), window);

+ transform_window_.window()->RemoveObserver(this);

transform_window_.OnWindowDestroyed();

WindowSelectorItem::RemoveWindow(window);

}