Update the window labels if they change in overview mode.

ash/wm/overview/window_selector_item.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/window_selector_item.h"
 
 #include "ash/screen_util.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/overview/scoped_transform_overview_window.h"
@@ skipping 123 matching lines @@
   target_bounds_ = target_bounds;
 
   // Set the bounds of the transparent window handler to cover the entire
   // bounding box area.
   if (!activate_window_button_) {
     activate_window_button_.reset(
         new TransparentActivateWindowButton(SelectionWindow()));
   }
   activate_window_button_->SetBounds(target_bounds);
 
-  // TODO(nsatragno): Handle window title updates.
   UpdateWindowLabels(target_bounds, root_window, animate);
 
   gfx::Rect inset_bounds(target_bounds);
   inset_bounds.Inset(kWindowMargin, kWindowMargin);
   SetItemBounds(root_window, inset_bounds, animate);
   UpdateCloseButtonBounds(root_window, animate);
 }
 
 void WindowSelectorItem::RecomputeWindowTransforms() {
   if (in_bounds_update_ || target_bounds_.IsEmpty())
     return;
   DCHECK(root_window_);
   base::AutoReset<bool> auto_reset_in_bounds_update(&in_bounds_update_, true);
   gfx::Rect inset_bounds(target_bounds_);
   inset_bounds.Inset(kWindowMargin, kWindowMargin);
   SetItemBounds(root_window_, inset_bounds, false);
   UpdateCloseButtonBounds(root_window_, false);
 }
 
 void WindowSelectorItem::SendFocusAlert() const {
   activate_window_button_->SendFocusAlert();
 }
 
 void WindowSelectorItem::ButtonPressed(views::Button* sender,
                                        const ui::Event& event) {
   views::Widget::GetWidgetForNativeView(SelectionWindow())->Close();
 }
 
+void WindowSelectorItem::OnWindowTitleChanged(aura::Window* window,
+                                              const base::string16& title) {
+  if (window == SelectionWindow()) {
+    static_cast<views::Label*>(

[sky, 2014/06/25 16:24:44]

static_casts like this are often times fragile, in so far as it's easy for
someone to change the contents view code and have this continue to compile and
only get crashes later on. I would rather you add the label as a member and use
said member here.

[Nina, 2014/06/25 19:54:40]

Okay, naturally I also replaced the other places in the code where the static
cast was done. Please give it a new look.

+        window_label_->GetContentsView())->SetText(title);
+  }
+}
+
 void WindowSelectorItem::UpdateCloseButtonBounds(aura::Window* root_window,
                                                  bool animate) {
   gfx::RectF align_bounds(ScreenUtil::ConvertRectFromScreen(
       root_window, SelectionWindow()->layer()->bounds()));
   gfx::Transform window_transform;
   window_transform.Translate(align_bounds.x(), align_bounds.y());
   window_transform.PreconcatTransform(SelectionWindow()->layer()->
                                           GetTargetTransform());
   window_transform.Translate(-align_bounds.x(), -align_bounds.y());
   window_transform.TransformRect(&align_bounds);
@@ skipping 105 matching lines @@
       settings.SetTransitionDuration(base::TimeDelta::FromMilliseconds(
           ScopedTransformOverviewWindow::kTransitionMilliseconds));
       window_label_->GetNativeWindow()->SetBounds(label_bounds);
     } else {
       window_label_->GetNativeWindow()->SetBounds(label_bounds);
     }
   }
 }
 
 }  // namespace ash