Update the window labels if they change in overview mode.

ash/wm/overview/window_selector_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "ash/accessibility_delegate.h"
 #include "ash/drag_drop/drag_drop_controller.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
@@ skipping 716 matching lines @@
   RunAllPendingInMessageLoop();
   EXPECT_FALSE(drag_canceled_by_test);
   ASSERT_TRUE(IsSelecting());
   RunAllPendingInMessageLoop();
 }
 
 // Test that a label is created under the window on entering overview mode.
 TEST_F(WindowSelectorTest, CreateLabelUnderWindow) {
   scoped_ptr<aura::Window> window(CreateWindow(gfx::Rect(0, 0, 100, 100)));
   base::string16 window_title = base::UTF8ToUTF16("My window");
-  window->set_title(window_title);
+  window->SetTitle(window_title);
   ToggleOverview();
   WindowSelectorItem* window_item = GetWindowItemsForRoot(0).back();
   views::Widget* widget = GetLabelWidget(window_item);
   // Has the label widget been created?
   ASSERT_TRUE(widget);
   views::Label* label = static_cast<views::Label*>(widget->GetContentsView());
   // Verify the label matches the window title.
   EXPECT_EQ(label->text(), window_title);
+
+  // Update the window title and check that the label is updated, too.
+  base::string16 updated_title = base::UTF8ToUTF16("Updated title");
+  window->SetTitle(updated_title);
+  EXPECT_EQ(label->text(), updated_title);
+
   // Labels are located based on target_bounds, not the actual window item
   // bounds.
   gfx::Rect target_bounds(window_item->target_bounds());
   gfx::Rect expected_label_bounds(target_bounds.x(),
                                   target_bounds.bottom(),
                                   target_bounds.width(),
                                   label->GetPreferredSize().height());
   gfx::Rect real_label_bounds = widget->GetNativeWindow()->bounds();
   EXPECT_EQ(widget->GetNativeWindow()->bounds(), real_label_bounds);
 }
 
 // Tests that a label is created for the active panel in a group of panels in
 // overview mode.
 TEST_F(WindowSelectorTest, CreateLabelUnderPanel) {
   scoped_ptr<aura::Window> panel1(CreatePanelWindow(gfx::Rect(0, 0, 100, 100)));
   scoped_ptr<aura::Window> panel2(CreatePanelWindow(gfx::Rect(0, 0, 100, 100)));
   base::string16 panel1_title = base::UTF8ToUTF16("My panel");
   base::string16 panel2_title = base::UTF8ToUTF16("Another panel");
-  panel1->set_title(panel1_title);
-  panel2->set_title(panel2_title);
+  panel1->SetTitle(panel1_title);
+  panel2->SetTitle(panel2_title);

[flackr, 2014/06/24 17:10:51]

Maybe test update of panel1 title and after deleting panel1, an update of panel2
title to cover the different observer behavior in panels?

[Nina, 2014/06/24 18:36:28]

Updated test to cover these cases plus changing the label of panel1.

   wm::ActivateWindow(panel1.get());
   ToggleOverview();
   WindowSelectorItem* window_item = GetWindowItemsForRoot(0).back();
   views::Widget* widget = GetLabelWidget(window_item);
   // Has the label widget been created?
   ASSERT_TRUE(widget);
   views::Label* label = static_cast<views::Label*>(widget->GetContentsView());
   // Verify the label matches the active window title.
   EXPECT_EQ(label->text(), panel1_title);
 }
@@ skipping 165 matching lines @@
 // cause selection to end.
 TEST_F(WindowSelectorTest, CloseButtonOnPanels) {
   scoped_ptr<views::Widget> widget1(CreatePanelWindowWidget(
       gfx::Rect(0, 0, 300, 100)));
   scoped_ptr<views::Widget> widget2(CreatePanelWindowWidget(
       gfx::Rect(100, 0, 100, 100)));
   aura::Window* window1 = widget1->GetNativeWindow();
   aura::Window* window2 = widget2->GetNativeWindow();
   base::string16 panel1_title = base::UTF8ToUTF16("Panel 1");
   base::string16 panel2_title = base::UTF8ToUTF16("Panel 2");
-  window1->set_title(panel1_title);
-  window2->set_title(panel2_title);
+  window1->SetTitle(panel1_title);
+  window2->SetTitle(panel2_title);
   wm::ActivateWindow(window1);
   ToggleOverview();
 
   gfx::RectF bounds1 = GetTransformedBoundsInRootWindow(window1);
   gfx::Point point1(bounds1.top_right().x() - 1, bounds1.top_right().y() - 1);
   aura::test::EventGenerator event_generator1(window1->GetRootWindow(), point1);
 
   EXPECT_FALSE(widget1->IsClosed());
   event_generator1.ClickLeftButton();
   EXPECT_TRUE(widget1->IsClosed());
@@ skipping 13 matching lines @@
   aura::test::EventGenerator event_generator2(window2->GetRootWindow(), point2);
 
   EXPECT_FALSE(widget2->IsClosed());
   event_generator2.ClickLeftButton();
   EXPECT_TRUE(widget2->IsClosed());
   RunAllPendingInMessageLoop();
   EXPECT_FALSE(IsSelecting());
 }
 
 }  // namespace ash