Update the window labels if they change in overview mode.

ash/wm/overview/window_selector_panels.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/window_selector_panels.h"
 
 #include "ash/screen_util.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/overview/scoped_transform_overview_window.h"
@@ skipping 74 matching lines @@
     : panels_root_window_(panels_root_window) {
   static_cast<PanelLayoutManager*>(
       Shell::GetContainer(panels_root_window_, kShellWindowId_PanelContainer)->
           layout_manager())->SetShowCalloutWidgets(false);
 }
 
 WindowSelectorPanels::~WindowSelectorPanels() {
   static_cast<PanelLayoutManager*>(
       Shell::GetContainer(panels_root_window_, kShellWindowId_PanelContainer)->
           layout_manager())->SetShowCalloutWidgets(true);
+  if (!transform_windows_.empty())
+    transform_windows_[0]->window()->RemoveObserver(this);

[flackr, 2014/06/24 17:10:51]

nit: For consistency use transform_windows_.front() here and elsewhere.

[Nina, 2014/06/24 18:36:28]

Done.

 }
 
 void WindowSelectorPanels::AddWindow(aura::Window* window) {
   DCHECK(window->GetRootWindow() == panels_root_window_);
+  // If this is the panel we use to get the label text, observe it for changes.
+  if (transform_windows_.empty())
+    window->AddObserver(this);
   transform_windows_.push_back(new ScopedTransformPanelWindow(window));
 }
 
 aura::Window* WindowSelectorPanels::GetRootWindow() {
   return transform_windows_.front()->window()->GetRootWindow();
 }
 
 bool WindowSelectorPanels::HasSelectableWindow(const aura::Window* window) {
   for (WindowList::const_iterator iter = transform_windows_.begin();
        iter != transform_windows_.end(); ++iter) {
@@ skipping 23 matching lines @@
 }
 
 aura::Window* WindowSelectorPanels::SelectionWindow() {
   return transform_windows_.front()->window();
 }
 
 void WindowSelectorPanels::RemoveWindow(const aura::Window* window) {
   for (WindowList::iterator iter = transform_windows_.begin();
        iter != transform_windows_.end(); ++iter) {
     if ((*iter)->window() == window) {
+      // If this is the first window, we are observing it for label changes,
+      // stop doing so before it is destructed.

[flackr, 2014/06/24 17:10:51]

I would also be fine with observing all of the windows but only updating the
label when the window we care about had a title change if it made this simpler.
Eventually I'd like to be able to handle bounds changes and other events in here
rather than having windowselector/windowgrid have to observe every window.

[Nina, 2014/06/24 18:36:28]

Changed the code to observe all of the transform windows, I agree that this does
make it simpler to transition to handling the bounds change in the
WindowSelectorItem.

+      if (window == transform_windows_[0]->window()) {
+        transform_windows_[0]->window()->RemoveObserver(this);
+        // If we still have windows after deletion, observe the next one.
+        if (transform_windows_.size() > 1)
+          transform_windows_[1]->window()->AddObserver(this);
+      }
       (*iter)->OnWindowDestroyed();
       transform_windows_.erase(iter);
       break;
     }
   }
   WindowSelectorItem::RemoveWindow(window);
 }
 
 bool WindowSelectorPanels::empty() const {
   return transform_windows_.empty();
@@ skipping 41 matching lines @@
     transform.Translate(bounding_rect.x() - bounds.x(),
                         bounding_rect.y() - bounds.y());
     transform.PreconcatTransform(bounding_transform);
     transform.Translate(bounds.x() - bounding_rect.x(),
                         bounds.y() - bounding_rect.y());
     (*iter)->SetTransform(root_window, transform, animate);
   }
 }
 
 }  // namespace ash