Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 331633002: Revert "Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen"" (Closed)

Created:
6 years, 6 months ago by danno
Modified:
6 years, 6 months ago
Reviewers:
Toon Verwaest, mtbrandy
CC:
v8-dev
Visibility:
Public.

Description

Revert "Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen"" This CL tickled an unrelated arm64 bug which was is fixed separately. The MIPS port (originally landed 21784) is also included. TBR=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21803

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+813 lines, -39 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +24 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +305 lines, -1 line 0 comments Download
M src/elements-kind.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/field-index.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/field-index-inl.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.h View 3 chunks +56 lines, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +201 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +48 lines, -3 lines 1 comment Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ic.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/ic.cc View 3 chunks +21 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +38 lines, -3 lines 1 comment Download
M src/runtime.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M src/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/keyed-load-dictionary-stub.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
6 years, 6 months ago (2014-06-12 09:38:51 UTC) #1
danno
Committed patchset #1 manually as r21803 (presubmit successful).
6 years, 6 months ago (2014-06-12 09:58:33 UTC) #2
Toon Verwaest
(rubberstamp) lgtm
6 years, 6 months ago (2014-06-12 09:58:48 UTC) #3
mtbrandy
This change introduces issues on big endian platforms. See inline comments. https://codereview.chromium.org/331633002/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): ...
6 years, 6 months ago (2014-06-17 13:45:40 UTC) #4
Paul Lind
6 years, 6 months ago (2014-06-17 15:41:21 UTC) #5
Message was sent while issue was closed.
On 2014/06/17 13:45:40, mtbrandy wrote:
> This change introduces issues on big endian platforms.  See inline comments.

I have a fix for this in https://codereview.chromium.org/334403003/ PTAL, and
add any comments, suggestions.

Powered by Google App Engine
This is Rietveld 408576698