Oilpan: Prepare to move EventQueue and its subclasses to Oilpan heap.

Oilpan: Prepare to move EventQueue and its subclasses to Oilpan heap.

This CL removes WTF_MAKE_FAST_ALLOCATED in TimerBase for Oilpan because
new/delete defined by it conflict with new/delete defined by GarbageCollected in
DOMWindowEventQueueTimer.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176064

[tkent, 2014-06-12 09:24:33]

Please review this.

[haraken, 2014-06-12 10:48:51]

LGTM

https://codereview.chromium.org/331623002/diff/1/Source/core/html/track/TextT...
File Source/core/html/track/TextTrackList.cpp (right):

https://codereview.chromium.org/331623002/diff/1/Source/core/html/track/TextT...
Source/core/html/track/TextTrackList.cpp:54: m_asyncEventQueue->close();

In non-oilpan builds, some destructors call close(), some destructors call
cancelAllEvents(), and some destructors do nothing. I think we need to do
nothing, because destroying OwnPtr<EventQueue> will gracefully clean up the
EventQueue.

So I think you can just remove close() and cancelAllEvents() from these
destructors instead of moving them to #if !ENABLE(OILPAN). However, I'm OK with
your CL to keep the current non-oilpan code as is.

[wibling-chromium, 2014-06-12 11:25:38]

lgtm

[zerny-chromium, 2014-06-12 14:02:13]

lgtm2

[tkent, 2014-06-12 23:50:12]

https://codereview.chromium.org/331623002/diff/1/Source/core/html/track/TextT...
File Source/core/html/track/TextTrackList.cpp (right):

https://codereview.chromium.org/331623002/diff/1/Source/core/html/track/TextT...
Source/core/html/track/TextTrackList.cpp:54: m_asyncEventQueue->close();
On 2014/06/12 10:48:51, haraken wrote:
> 
> In non-oilpan builds, some destructors call close(), some destructors call
> cancelAllEvents(), and some destructors do nothing. I think we need to do
> nothing, because destroying OwnPtr<EventQueue> will gracefully clean up the
> EventQueue.
> 
> So I think you can just remove close() and cancelAllEvents() from these
> destructors instead of moving them to #if !ENABLE(OILPAN). However, I'm OK
with
> your CL to keep the current non-oilpan code as is.

I'd like to keep non-oilpan code.

[tkent, 2014-06-12 23:50:17]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-12 23:50:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/331623002/1

[commit-bot: I haz the power, 2014-06-12 23:55:16]

Change committed as 176064

[sof, 2014-06-13 06:06:33]

Appears to have broken unit tests?


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20...

[sof, 2014-06-13 06:20:08]

On 2014/06/13 06:06:33, sof wrote:
> Appears to have broken unit tests?
> 
> 
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20...

Taking care of it.