components/autofill/core/common/save_password_progress_logger.cc - Issue 331593008: Only consider PasswordFromManager which HasCompletedMatching when provisionally saving passwords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 331593008: Only consider PasswordFromManager which HasCompletedMatching when provisionally saving passwords (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Test added Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/password/form_utils.js ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 25bfafc986d3b429e1991ebaf781198b4e7e1c9d..3f2724fccc312eccdbdff6fa679b85c5a669c2ff 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -137,8 +137,8 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "Form manager found, exact match.";

case SavePasswordProgressLogger::STRING_MATCH_WITHOUT_ACTION:

return "Form manager found, match except for action.";

- case SavePasswordProgressLogger::STRING_NO_FORM_MANAGER:

- return "No form manager found.";

+ case SavePasswordProgressLogger::STRING_MATCHING_NOT_COMPLETE:

+ return "No form manager completed matching.";

case SavePasswordProgressLogger::STRING_FORM_BLACKLISTED:

return "Form blacklisted.";

case SavePasswordProgressLogger::STRING_INVALID_FORM: