chrome/test/data/password/between_parsing_and_rendering.html - Issue 331593008: Only consider PasswordFromManager which HasCompletedMatching when provisionally saving passwords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/password/between_parsing_and_rendering.html

Issue 331593008: Only consider PasswordFromManager which HasCompletedMatching when provisionally saving passwords (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added missing copyright notice in the JavaScript file Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/create_form_copy_on_submit.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/password/between_parsing_and_rendering.html

diff --git a/chrome/test/data/password/between_parsing_and_rendering.html b/chrome/test/data/password/between_parsing_and_rendering.html

index 320c1b751c6e2ed241f18a3558a3e15ec990e95d..f7bb3e3949e5b16e6d5d505afed6972868923c91 100644

--- a/chrome/test/data/password/between_parsing_and_rendering.html

+++ b/chrome/test/data/password/between_parsing_and_rendering.html

@@ -23,47 +23,10 @@ some webkit-only rules for background properties.

-->

<html>

<head>

+ <script src="form_utils.js"></script>

-function createForm() {

- var form = document.createElement('form');

- form.setAttribute('action', 'done.html');

- var username_label = document.createElement('label');

- username_label.setAttribute('for', 'username');

- username_label.innerText = 'Username: ';

- var username = document.createElement('input');

- username.type = 'text';

- username.name = 'username';

- username.id = 'username';

- var password_label = document.createElement('label');

- password_label.innerText = 'Password: ';

- password_label.setAttribute('for', 'password');

- var password = document.createElement('input');

- password.type = 'password';

- password.name = 'password';

- password.id = 'password';

- var submit = document.createElement('input');

- submit.type = 'submit';

- submit.id = 'submit-button';

- submit.value = 'Submit';

- form.appendChild(username_label);

- form.appendChild(username);

- form.appendChild(password_label);

- form.appendChild(password);

- form.appendChild(submit);

- return form;

-function addForm(form) {

- document.getElementsByTagName('body')[0].appendChild(form);

function onLoadHandler() {

- addForm(createForm());

+ document.body.appendChild(createSimplePasswordForm());

}

</script>

<style>