Only consider PasswordFromManager which HasCompletedMatching when provisionally saving passwords

chrome/browser/password_manager/password_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/run_loop.h"
@@ skipping 1065 matching lines @@
     ui_controller()->SavePassword();
   } else {
     EXPECT_TRUE(nav_observer.infobar_shown());
   }
   // Spin the message loop to make sure the password store had a chance to save
   // the password.
   base::RunLoop run_loop;
   run_loop.RunUntilIdle();
   EXPECT_FALSE(password_store->IsEmpty());
 }
+
+// In some situations, multiple PasswordFormManager instances from
+// PasswordManager::pending_login_managers_ would match (via DoesManage) a form
+// to be provisionally saved. One of them might be a complete match, the other
+// all-but-action match. Normally, the former should be preferred, but if the
+// former did not finished matching, and the latter did, the latter should be

[engedy, 2014/07/11 17:05:35]

nit: s/did/has/

[vabr (Chromium), 2014/07/11 18:15:47]

Done.

+// used (otherwise we'd give up even though we could have saved the password).
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       TryToUsePasswordFormManagerWhichFinishedMatching) {

[engedy, 2014/07/11 17:05:35]

nit: s/TryToUse/Prefer/

[vabr (Chromium), 2014/07/11 18:15:47]

Done.

+  NavigateToFile("/password/create_form_copy_on_submit.html");
+
+  NavigationObserver observer(WebContents());
+  std::string submit =
+      "document.getElementById('username').value = 'overwrite_me';"
+      "document.getElementById('password').value = 'random';"
+      "document.getElementById('non-form-button').click();";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), submit));
+  observer.Wait();
+
+  if (ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled()) {
+    EXPECT_TRUE(ui_controller()->PasswordPendingUserDecision());
+  } else {
+    EXPECT_TRUE(observer.infobar_shown());
+  }
+}
+