Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/bisect_utils.py

Issue 331593007: Enable manual bisects on Chrome for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Ross's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bisect-perf-regression.py ('k') | tools/run-bisect-manual-test.py » ('j') | tools/run-bisect-manual-test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect_utils.py
diff --git a/tools/bisect_utils.py b/tools/bisect_utils.py
index 650288f163ca2747ab51f37fd285dec9204ec2cd..a0c05a3af8f6e5127e0d4c42a6e4295632649446 100644
--- a/tools/bisect_utils.py
+++ b/tools/bisect_utils.py
@@ -458,6 +458,9 @@ def SetupAndroidBuildEnvironment(opts, path_to_src=None):
except KeyError:
os.environ['GYP_DEFINES'] = 'OS=android'
+ if opts.use_goma:
+ os.environ['GYP_DEFINES'] = '%s %s' % (os.environ['GYP_DEFINES'],
+ 'use_goma=1')
rmcilroy 2014/06/17 17:20:12 nit - align to brackets.
aberent 2014/06/18 10:10:10 Done.
return not proc.returncode
« no previous file with comments | « tools/bisect-perf-regression.py ('k') | tools/run-bisect-manual-test.py » ('j') | tools/run-bisect-manual-test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698