Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: tools/bisect_utils.py

Issue 331593007: Enable manual bisects on Chrome for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Put use_goma test in the right place Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Set of operations/utilities related to checking out the depot, and 5 """Set of operations/utilities related to checking out the depot, and
6 outputting annotations on the buildbot waterfall. These are intended to be 6 outputting annotations on the buildbot waterfall. These are intended to be
7 used by the bisection scripts.""" 7 used by the bisection scripts."""
8 8
9 import errno 9 import errno
10 import imp 10 import imp
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 # envsetup.sh no longer sets OS=android to GYP_DEFINES env variable 451 # envsetup.sh no longer sets OS=android to GYP_DEFINES env variable
452 # (CL/170273005). Set this variable explicitly inorder to build chrome on 452 # (CL/170273005). Set this variable explicitly inorder to build chrome on
453 # android. 453 # android.
454 try: 454 try:
455 if 'OS=android' not in os.environ['GYP_DEFINES']: 455 if 'OS=android' not in os.environ['GYP_DEFINES']:
456 os.environ['GYP_DEFINES'] = '%s %s' % (os.environ['GYP_DEFINES'], 456 os.environ['GYP_DEFINES'] = '%s %s' % (os.environ['GYP_DEFINES'],
457 'OS=android') 457 'OS=android')
458 except KeyError: 458 except KeyError:
459 os.environ['GYP_DEFINES'] = 'OS=android' 459 os.environ['GYP_DEFINES'] = 'OS=android'
460 460
461 if opts.use_goma:
462 os.environ['GYP_DEFINES'] = '%s %s' % (os.environ['GYP_DEFINES'],
463 'use_goma=1')
461 return not proc.returncode 464 return not proc.returncode
462 465
463 466
464 def SetupPlatformBuildEnvironment(opts): 467 def SetupPlatformBuildEnvironment(opts):
465 """Performs any platform specific setup. 468 """Performs any platform specific setup.
466 469
467 Args: 470 Args:
468 opts: The options parsed from the command line through parse_args(). 471 opts: The options parsed from the command line through parse_args().
469 472
470 Returns: 473 Returns:
(...skipping 27 matching lines...) Expand all
498 501
499 Args: 502 Args:
500 opts: The options parsed from the command line through parse_args(). 503 opts: The options parsed from the command line through parse_args().
501 custom_deps: A dictionary of additional dependencies to add to .gclient. 504 custom_deps: A dictionary of additional dependencies to add to .gclient.
502 """ 505 """
503 if not CreateAndChangeToSourceDirectory(opts.working_directory): 506 if not CreateAndChangeToSourceDirectory(opts.working_directory):
504 raise RuntimeError('Could not create bisect directory.') 507 raise RuntimeError('Could not create bisect directory.')
505 508
506 if not SetupGitDepot(opts, custom_deps): 509 if not SetupGitDepot(opts, custom_deps):
507 raise RuntimeError('Failed to grab source.') 510 raise RuntimeError('Failed to grab source.')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698