Issue 331593005: athena: Allow scrolling the window list in overview mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331593005: athena: Allow scrolling the window list in overview mode. (Closed)

Created:
6 years, 6 months ago by sadrul

Modified:
6 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

athena: Allow scrolling the window list in overview mode. Allow scrolling the window list in overview mode using touch-scroll, wheel scroll or touchpad scroll. BUG=376353 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277029

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -13 lines)			Patch
	M	athena/wm/window_overview_mode.cc	View	1 2	2 chunks	+67 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sadrul

I expect that the math for the scroll-updates will change, but what is in here ...

6 years, 6 months ago (2014-06-13 03:58:46 UTC) #1

oshima

lgtm with a nit https://codereview.chromium.org/331593005/diff/20001/athena/wm/window_overview_mode.cc File athena/wm/window_overview_mode.cc (right): https://codereview.chromium.org/331593005/diff/20001/athena/wm/window_overview_mode.cc#newcode24 athena/wm/window_overview_mode.cc:24: const float kEpsilon = 1e-3f; ...

6 years, 6 months ago (2014-06-13 05:26:50 UTC) #2

sadrul

https://codereview.chromium.org/331593005/diff/20001/athena/wm/window_overview_mode.cc File athena/wm/window_overview_mode.cc (right): https://codereview.chromium.org/331593005/diff/20001/athena/wm/window_overview_mode.cc#newcode24 athena/wm/window_overview_mode.cc:24: const float kEpsilon = 1e-3f; On 2014/06/13 05:26:50, oshima ...

6 years, 6 months ago (2014-06-13 14:00:09 UTC) #3

sadrul

6 years, 6 months ago (2014-06-13 15:21:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r277029 (presubmit successful).

Expand Messages | Collapse Messages