Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5814)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 331583003: Files.app: Add a test to open a file dialog box. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/file_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index b2c26487275124f316197764e9d7f3b9b2b12f34..3462d1a79565d268f9dd527ba2be026042464aa4 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -965,7 +965,7 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#define MAYBE_ExecuteDefaultTaskOnDrive ExecuteDefaultTaskOnDrive
#endif
INSTANTIATE_TEST_CASE_P(
- ExecuteDefaultTaskOnDrive,
+ MAYBE_ExecuteDefaultTaskOnDrive,
FileManagerBrowserTest,
::testing::Values(
TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDrive")));
@@ -1026,6 +1026,21 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "thumbnailsDownloads"),
TestParameter(IN_GUEST_MODE, "thumbnailsDownloads")));
+#if !defined(NDEBUG)
+#define MAYBE_OpenFileDialog DISABLED_OpenFileDialog
+#else
+#define MAYBE_OpenFileDialog OpenFileDialog
+#endif
+WRAPPED_INSTANTIATE_TEST_CASE_P(
+ MAYBE_OpenFileDialog,
+ FileManagerBrowserTest,
+ ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
+ "openFileDialogOnDownloads"),
+ TestParameter(IN_GUEST_MODE,
+ "openFileDialogOnDownloads"),
+ TestParameter(NOT_IN_GUEST_MODE,
+ "openFileDialogOnDrive")));
+
// Slow tests are disabled on debug build. http://crbug.com/327719
#if !defined(NDEBUG)
#define MAYBE_CopyBetweenWindows DISABLED_CopyBetweenWindows
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/file_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698