Issue 331583002: Oilpan: |SVGViewSpec::m_contextElement| should be a member.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331583002: Oilpan: |SVGViewSpec::m_contextElement| should be a member. (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: |SVGViewSpec::m_contextElement| should be a member. r175772 changed lifetime of SVGViewSpec to be always same as SVGSVGElement, so this weak-ref can now be made a strong-ref. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176001

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	Source/core/svg/SVGViewSpec.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	Source/core/svg/SVGViewSpec.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/331583002/1

6 years, 6 months ago (2014-06-12 05:38:50 UTC) #4

Message was sent while issue was closed.

Change committed as 176001

Expand Messages | Collapse Messages