Get rid of hack in invalidatePaintUsingContainer for partially computed

Source/core/rendering/RenderObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1493 matching lines @@
 
     // FIXME: This should be an assert, but editing/selection can trigger this case to invalidate
     // the selection. crbug.com/368140.
     if (!isRooted())
         return;
 
     TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "RenderObject::invalidatePaintUsingContainer()",
         "object", this->debugName().ascii(),
         "info", TracedValue::fromJSONValue(jsonObjectForPaintInvalidationInfo(r, invalidationReasonToString(invalidationReason))));
 
-    // FIXME: Don't read compositing state here since we do this in the middle of recalc/layout.
+    // For querying RenderLayer::compositingState()
     DisableCompositingQueryAsserts disabler;

[dsinclair, 2014/06/13 17:50:04]

Can this be moved down into the if (v->usesCompositing()) block to limit the
scope?

[chrishtr, 2014/06/13 22:46:49]

Per top-level comments, it can't be moved down.

-    if (paintInvalidationContainer->compositingState() == PaintsIntoGroupedBacking) {
-        ASSERT(paintInvalidationContainer->groupedMapping());
-        ASSERT(paintInvalidationContainer->layer());
-
-        // Not clean, but if squashing layer does not yet exist here (e.g. paint invalidation coming from within recomputing compositing requirements)
-        // then it's ok to just exit here, since the squashing layer will get invalidate when it is newly created.
-        if (!paintInvalidationContainer->groupedMapping()->squashingLayer())
-            return;
-    }
 
     if (paintInvalidationContainer->isRenderFlowThread()) {
         toRenderFlowThread(paintInvalidationContainer)->repaintRectangleInRegions(r);
         return;
     }
 
     if (paintInvalidationContainer->hasFilter() && paintInvalidationContainer->layer()->requiresFullLayerImageForFilters()) {
         paintInvalidationContainer->layer()->repainter().setFilterBackendNeedsRepaintingInRect(r);
         return;
     }
@@ skipping 2015 matching lines @@
 {
     if (object1) {
         const WebCore::RenderObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
     }
 }
 
 #endif