Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3790)

Unified Diff: cc/surfaces/surface_manager.cc

Issue 331533002: Use a struct for cc::Surface ids for more type safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add is_null and explicit ctor Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/surfaces/surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.cc
diff --git a/cc/surfaces/surface_manager.cc b/cc/surfaces/surface_manager.cc
index 366fa81c70e62df6cef0d0121ec90655bf5ce00f..b41aefc424a392cf9cdc8de0684a3f5f587e0b06 100644
--- a/cc/surfaces/surface_manager.cc
+++ b/cc/surfaces/surface_manager.cc
@@ -14,21 +14,21 @@ SurfaceManager::SurfaceManager()
SurfaceManager::~SurfaceManager() {}
-int SurfaceManager::RegisterAndAllocateIDForSurface(Surface* surface) {
+SurfaceId SurfaceManager::RegisterAndAllocateIdForSurface(Surface* surface) {
DCHECK(surface);
int surface_id = next_surface_id_++;
surface_map_[surface_id] = surface;
- return surface_id;
+ return SurfaceId(surface_id);
}
-void SurfaceManager::DeregisterSurface(int surface_id) {
- SurfaceMap::iterator it = surface_map_.find(surface_id);
+void SurfaceManager::DeregisterSurface(SurfaceId surface_id) {
+ SurfaceMap::iterator it = surface_map_.find(surface_id.id);
DCHECK(it != surface_map_.end());
surface_map_.erase(it);
}
-Surface* SurfaceManager::GetSurfaceForID(int surface_id) {
- SurfaceMap::iterator it = surface_map_.find(surface_id);
+Surface* SurfaceManager::GetSurfaceForId(SurfaceId surface_id) {
+ SurfaceMap::iterator it = surface_map_.find(surface_id.id);
if (it == surface_map_.end())
return NULL;
return it->second;
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/surfaces/surface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698