Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: cc/surfaces/surface_unittest.cc

Issue 331533002: Use a struct for cc::Surface ids for more type safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add is_null and explicit ctor Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/surface.h" 5 #include "cc/surfaces/surface.h"
6 #include "cc/surfaces/surface_manager.h" 6 #include "cc/surfaces/surface_manager.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "ui/gfx/size.h" 8 #include "ui/gfx/size.h"
9 9
10 namespace cc { 10 namespace cc {
11 namespace { 11 namespace {
12 12
13 TEST(SurfaceTest, SurfaceLifetime) { 13 TEST(SurfaceTest, SurfaceLifetime) {
14 SurfaceManager manager; 14 SurfaceManager manager;
15 15
16 int surface_id = 0; 16 SurfaceId surface_id;
17 { 17 {
18 Surface surface(&manager, NULL, gfx::Size(5, 5)); 18 Surface surface(&manager, NULL, gfx::Size(5, 5));
19 surface_id = surface.surface_id(); 19 surface_id = surface.surface_id();
20 EXPECT_GT(surface_id, 0); 20 EXPECT_TRUE(!surface_id.is_null());
21 EXPECT_EQ(&surface, manager.GetSurfaceForID(surface_id)); 21 EXPECT_EQ(&surface, manager.GetSurfaceForId(surface_id));
22 } 22 }
23 23
24 EXPECT_EQ(NULL, manager.GetSurfaceForID(surface_id)); 24 EXPECT_EQ(NULL, manager.GetSurfaceForId(surface_id));
25 } 25 }
26 26
27 } // namespace 27 } // namespace
28 } // namespace cc 28 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/surface_manager.cc ('k') | content/browser/compositor/surface_display_output_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698