Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: cc/surfaces/surface_aggregator_test_helpers.h

Issue 331533002: Use a struct for cc::Surface ids for more type safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add is_null and explicit ctor Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/surfaces/surface_aggregator.cc ('k') | cc/surfaces/surface_aggregator_test_helpers.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_SURFACE_AGGREGATOR_TEST_HELPERS_H_ 5 #ifndef CC_SURFACES_SURFACE_AGGREGATOR_TEST_HELPERS_H_
6 #define CC_SURFACES_SURFACE_AGGREGATOR_TEST_HELPERS_H_ 6 #define CC_SURFACES_SURFACE_AGGREGATOR_TEST_HELPERS_H_
7 7
8 #include "cc/quads/draw_quad.h" 8 #include "cc/quads/draw_quad.h"
9 #include "cc/quads/render_pass.h" 9 #include "cc/quads/render_pass.h"
10 #include "cc/surfaces/surface_id.h"
10 #include "third_party/skia/include/core/SkColor.h" 11 #include "third_party/skia/include/core/SkColor.h"
11 #include "ui/gfx/size.h" 12 #include "ui/gfx/size.h"
12 13
13 namespace cc { 14 namespace cc {
14 15
15 class Surface; 16 class Surface;
16 class TestRenderPass; 17 class TestRenderPass;
17 18
18 namespace test { 19 namespace test {
19 20
20 struct Quad { 21 struct Quad {
21 static Quad SolidColorQuad(SkColor color) { 22 static Quad SolidColorQuad(SkColor color) {
22 Quad quad; 23 Quad quad;
23 quad.material = DrawQuad::SOLID_COLOR; 24 quad.material = DrawQuad::SOLID_COLOR;
24 quad.color = color; 25 quad.color = color;
25 return quad; 26 return quad;
26 } 27 }
27 28
28 static Quad SurfaceQuad(int surface_id) { 29 static Quad SurfaceQuad(SurfaceId surface_id) {
29 Quad quad; 30 Quad quad;
30 quad.material = DrawQuad::SURFACE_CONTENT; 31 quad.material = DrawQuad::SURFACE_CONTENT;
31 quad.surface_id = surface_id; 32 quad.surface_id = surface_id;
32 return quad; 33 return quad;
33 } 34 }
34 35
35 static Quad RenderPassQuad(RenderPass::Id id) { 36 static Quad RenderPassQuad(RenderPass::Id id) {
36 Quad quad; 37 Quad quad;
37 quad.material = DrawQuad::RENDER_PASS; 38 quad.material = DrawQuad::RENDER_PASS;
38 quad.render_pass_id = id; 39 quad.render_pass_id = id;
39 return quad; 40 return quad;
40 } 41 }
41 42
42 DrawQuad::Material material; 43 DrawQuad::Material material;
43 // Set when material==DrawQuad::SURFACE_CONTENT. 44 // Set when material==DrawQuad::SURFACE_CONTENT.
44 int surface_id; 45 SurfaceId surface_id;
45 // Set when material==DrawQuad::SOLID_COLOR. 46 // Set when material==DrawQuad::SOLID_COLOR.
46 SkColor color; 47 SkColor color;
47 // Set when material==DrawQuad::RENDER_PASS. 48 // Set when material==DrawQuad::RENDER_PASS.
48 RenderPass::Id render_pass_id; 49 RenderPass::Id render_pass_id;
49 50
50 private: 51 private:
51 Quad() 52 Quad()
52 : material(DrawQuad::INVALID), 53 : material(DrawQuad::INVALID),
53 surface_id(-1),
54 color(SK_ColorWHITE), 54 color(SK_ColorWHITE),
55 render_pass_id(-1, -1) {} 55 render_pass_id(-1, -1) {}
56 }; 56 };
57 57
58 struct Pass { 58 struct Pass {
59 Pass(Quad* quads, size_t quad_count, RenderPass::Id id) 59 Pass(Quad* quads, size_t quad_count, RenderPass::Id id)
60 : quads(quads), quad_count(quad_count), id(id) {} 60 : quads(quads), quad_count(quad_count), id(id) {}
61 Pass(Quad* quads, size_t quad_count) 61 Pass(Quad* quads, size_t quad_count)
62 : quads(quads), quad_count(quad_count), id(1, 1) {} 62 : quads(quads), quad_count(quad_count), id(1, 1) {}
63 63
(...skipping 22 matching lines...) Expand all
86 RenderPassList* passes); 86 RenderPassList* passes);
87 87
88 void SubmitFrame(Pass* passes, size_t pass_count, Surface* surface); 88 void SubmitFrame(Pass* passes, size_t pass_count, Surface* surface);
89 89
90 void QueuePassAsFrame(scoped_ptr<RenderPass> pass, Surface* surface); 90 void QueuePassAsFrame(scoped_ptr<RenderPass> pass, Surface* surface);
91 91
92 } // namespace test 92 } // namespace test
93 } // namespace cc 93 } // namespace cc
94 94
95 #endif // CC_SURFACES_SURFACE_AGGREGATOR_TEST_HELPERS_H_ 95 #endif // CC_SURFACES_SURFACE_AGGREGATOR_TEST_HELPERS_H_
OLDNEW
« no previous file with comments | « cc/surfaces/surface_aggregator.cc ('k') | cc/surfaces/surface_aggregator_test_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698