Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: cc/surfaces/surface.h

Issue 331533002: Use a struct for cc::Surface ids for more type safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add is_null and explicit ctor Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/surfaces/display.cc ('k') | cc/surfaces/surface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_SURFACE_H_ 5 #ifndef CC_SURFACES_SURFACE_H_
6 #define CC_SURFACES_SURFACE_H_ 6 #define CC_SURFACES_SURFACE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "cc/surfaces/surface_id.h"
10 #include "cc/surfaces/surfaces_export.h" 11 #include "cc/surfaces/surfaces_export.h"
11 #include "ui/gfx/size.h" 12 #include "ui/gfx/size.h"
12 13
13 namespace cc { 14 namespace cc {
14 class CompositorFrame; 15 class CompositorFrame;
15 class SurfaceManager; 16 class SurfaceManager;
16 class SurfaceClient; 17 class SurfaceClient;
17 18
18 class CC_SURFACES_EXPORT Surface { 19 class CC_SURFACES_EXPORT Surface {
19 public: 20 public:
20 Surface(SurfaceManager* manager, 21 Surface(SurfaceManager* manager,
21 SurfaceClient* client, 22 SurfaceClient* client,
22 const gfx::Size& size); 23 const gfx::Size& size);
23 ~Surface(); 24 ~Surface();
24 25
25 const gfx::Size& size() const { return size_; } 26 const gfx::Size& size() const { return size_; }
26 int surface_id() const { return surface_id_; } 27 SurfaceId surface_id() const { return surface_id_; }
27 28
28 void QueueFrame(scoped_ptr<CompositorFrame> frame); 29 void QueueFrame(scoped_ptr<CompositorFrame> frame);
29 // Returns the most recent frame that is eligible to be rendered. 30 // Returns the most recent frame that is eligible to be rendered.
30 CompositorFrame* GetEligibleFrame(); 31 CompositorFrame* GetEligibleFrame();
31 32
32 private: 33 private:
33 SurfaceManager* manager_; 34 SurfaceManager* manager_;
34 SurfaceClient* client_; 35 SurfaceClient* client_;
35 gfx::Size size_; 36 gfx::Size size_;
36 int surface_id_; 37 SurfaceId surface_id_;
37 // TODO(jamesr): Support multiple frames in flight. 38 // TODO(jamesr): Support multiple frames in flight.
38 scoped_ptr<CompositorFrame> current_frame_; 39 scoped_ptr<CompositorFrame> current_frame_;
39 40
40 DISALLOW_COPY_AND_ASSIGN(Surface); 41 DISALLOW_COPY_AND_ASSIGN(Surface);
41 }; 42 };
42 43
43 } // namespace cc 44 } // namespace cc
44 45
45 #endif // CC_SURFACES_SURFACE_H_ 46 #endif // CC_SURFACES_SURFACE_H_
OLDNEW
« no previous file with comments | « cc/surfaces/display.cc ('k') | cc/surfaces/surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698