Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: cc/layers/surface_layer_impl.h

Issue 331533002: Use a struct for cc::Surface ids for more type safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add is_null and explicit ctor Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/layers/surface_layer.cc ('k') | cc/layers/surface_layer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_SURFACE_LAYER_IMPL_H_ 5 #ifndef CC_LAYERS_SURFACE_LAYER_IMPL_H_
6 #define CC_LAYERS_SURFACE_LAYER_IMPL_H_ 6 #define CC_LAYERS_SURFACE_LAYER_IMPL_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "cc/base/cc_export.h" 9 #include "cc/base/cc_export.h"
10 #include "cc/layers/layer_impl.h" 10 #include "cc/layers/layer_impl.h"
11 #include "cc/surfaces/surface_id.h"
11 12
12 namespace cc { 13 namespace cc {
13 14
14 class CC_EXPORT SurfaceLayerImpl : public LayerImpl { 15 class CC_EXPORT SurfaceLayerImpl : public LayerImpl {
15 public: 16 public:
16 static scoped_ptr<SurfaceLayerImpl> Create(LayerTreeImpl* tree_impl, int id) { 17 static scoped_ptr<SurfaceLayerImpl> Create(LayerTreeImpl* tree_impl, int id) {
17 return make_scoped_ptr(new SurfaceLayerImpl(tree_impl, id)); 18 return make_scoped_ptr(new SurfaceLayerImpl(tree_impl, id));
18 } 19 }
19 virtual ~SurfaceLayerImpl(); 20 virtual ~SurfaceLayerImpl();
20 21
21 void SetSurfaceId(int surface_id); 22 void SetSurfaceId(SurfaceId surface_id);
22 23
23 // LayerImpl overrides. 24 // LayerImpl overrides.
24 virtual scoped_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl) 25 virtual scoped_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl)
25 OVERRIDE; 26 OVERRIDE;
26 virtual void PushPropertiesTo(LayerImpl* layer) OVERRIDE; 27 virtual void PushPropertiesTo(LayerImpl* layer) OVERRIDE;
27 virtual void AppendQuads(QuadSink* quad_sink, 28 virtual void AppendQuads(QuadSink* quad_sink,
28 AppendQuadsData* append_quads_data) OVERRIDE; 29 AppendQuadsData* append_quads_data) OVERRIDE;
29 30
30 protected: 31 protected:
31 SurfaceLayerImpl(LayerTreeImpl* tree_impl, int id); 32 SurfaceLayerImpl(LayerTreeImpl* tree_impl, int id);
32 33
33 private: 34 private:
34 virtual void GetDebugBorderProperties(SkColor* color, 35 virtual void GetDebugBorderProperties(SkColor* color,
35 float* width) const OVERRIDE; 36 float* width) const OVERRIDE;
36 virtual void AsValueInto(base::DictionaryValue* dict) const OVERRIDE; 37 virtual void AsValueInto(base::DictionaryValue* dict) const OVERRIDE;
37 virtual const char* LayerTypeAsString() const OVERRIDE; 38 virtual const char* LayerTypeAsString() const OVERRIDE;
38 39
39 int surface_id_; 40 SurfaceId surface_id_;
40 41
41 DISALLOW_COPY_AND_ASSIGN(SurfaceLayerImpl); 42 DISALLOW_COPY_AND_ASSIGN(SurfaceLayerImpl);
42 }; 43 };
43 44
44 } // namespace cc 45 } // namespace cc
45 46
46 #endif // CC_LAYERS_SURFACE_LAYER_IMPL_H_ 47 #endif // CC_LAYERS_SURFACE_LAYER_IMPL_H_
OLDNEW
« no previous file with comments | « cc/layers/surface_layer.cc ('k') | cc/layers/surface_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698