Issue 331493006: GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representati…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331493006: GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representati… (Closed)

Created:
6 years, 6 months ago by Igor Sheludko

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representation is not the same. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21830

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	src/hydrogen-gvn.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+8 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-gvn-ftt.js	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Igor Sheludko

6 years, 6 months ago (2014-06-13 07:51:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21830 (presubmit successful).