Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 331443004: GCMDriver.java should start the browser processes if necessary (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix checkdeps Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/gcm_driver.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/findbugs_filter/findbugs_exclude.xml
diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index bf0e51f6945d6b70797f43ee79053dbfeb86383f..59aa92fd1ed246ff468f9765f53a203d4ad24297 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -89,6 +89,11 @@ In particular, ~ at the start of a string means it's a regex.
<Method name="onCreate" />
<Bug code="Dm" />
</Match>
+ <Match>
+ <Class name="~org\.chromium\.components\.gcm_driver\..*\.GCMDriver" />
+ <Method name="launchNativeThen" />
+ <Bug code="Dm" />
+ </Match>
<!--
Ignore write to static field in GCMDriver, as it's the cleanest way to mark
the singleton as null when the native counterpart is destroyed.
« no previous file with comments | « no previous file | components/gcm_driver.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698