Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 331443003: third try at landing improved blur rect; this time with more correctness (Closed)

Created:
6 years, 6 months ago by humper
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

third try at landing improved blur rect; this time with more correctness BUG=skia:2095 R=bsalomon@google.com TBR=bsalomon Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f

Patch Set 1 #

Patch Set 2 : trying to apply patch to attempt 3 so brian can look #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -101 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +25 lines, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 8 chunks +92 lines, -94 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-06-11 19:28:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/331443003/1
6 years, 6 months ago (2014-06-11 19:29:20 UTC) #2
reed1
If this will trigger layouttest failures, can we delay landing this in skia until we ...
6 years, 6 months ago (2014-06-11 19:30:50 UTC) #3
scroggo
On 2014/06/11 19:30:50, reed1 wrote: > If this will trigger layouttest failures, can we delay ...
6 years, 6 months ago (2014-06-11 19:40:25 UTC) #4
reed1
On 2014/06/11 19:40:25, scroggo wrote: > On 2014/06/11 19:30:50, reed1 wrote: > > If this ...
6 years, 6 months ago (2014-06-11 19:41:54 UTC) #5
commit-bot: I haz the power
Change committed as 72abfc2b4e7caead660f6b6a05e60d05eaf1a66f
6 years, 6 months ago (2014-06-11 19:42:55 UTC) #6
scroggo
6 years, 6 months ago (2014-06-12 19:10:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/333763002/ by scroggo@google.com.

The reason for reverting is: Failing layout test:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/327....

Powered by Google App Engine
This is Rietveld 408576698