hide SkImageDecoder::Chooser

hide SkImageDecoder::Chooser

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5926b86b90c68bffefbdc8639e41b5bc9102cec6

[reed1, 2014-06-11 15:28:29]

did not define the flag anywhere, but keeping it just as a safe-guard.

[scroggo, 2014-06-11 17:11:23]

lgtm

https://codereview.chromium.org/331433003/diff/1/src/images/SkImageDecoder_li...
File src/images/SkImageDecoder_libico.cpp (right):

https://codereview.chromium.org/331433003/diff/1/src/images/SkImageDecoder_li...
src/images/SkImageDecoder_libico.cpp:99: Chooser* chooser = this->getChooser();
ICO is the prime example where the choice actually is meaningful, since an ICO
may contain multiple images - I think other image formats can support this as
well, but I don't know how many images use it in practice, and no clients use
it.

It might be nice to support this feature, but it's reasonable to wait for a
client to request it (which may give us a better idea of what the API should
look like).

[reed1, 2014-06-11 17:19:52]

On 2014/06/11 17:11:23, scroggo wrote:
> lgtm
> 
>
https://codereview.chromium.org/331433003/diff/1/src/images/SkImageDecoder_li...
> File src/images/SkImageDecoder_libico.cpp (right):
> 
>
https://codereview.chromium.org/331433003/diff/1/src/images/SkImageDecoder_li...
> src/images/SkImageDecoder_libico.cpp:99: Chooser* chooser =
this->getChooser();
> ICO is the prime example where the choice actually is meaningful, since an ICO
> may contain multiple images - I think other image formats can support this as
> well, but I don't know how many images use it in practice, and no clients use
> it.
> 
> It might be nice to support this feature, but it's reasonable to wait for a
> client to request it (which may give us a better idea of what the API should
> look like).

Agreed. Adding it back in (if needed) shouldn't be hard.

[reed1, 2014-06-11 17:20:01]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-06-11 17:21:03]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/331433003/1

[commit-bot: I haz the power, 2014-06-11 17:33:17]

Change committed as 5926b86b90c68bffefbdc8639e41b5bc9102cec6