Pull GetMutableValue from Perisistent to WritablePrefStore.

base/prefs/persistent_pref_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PREFS_PERSISTENT_PREF_STORE_H_
 #define BASE_PREFS_PERSISTENT_PREF_STORE_H_
 
 #include <string>
 
 #include "base/prefs/base_prefs_export.h"
@@ skipping 28 matching lines @@
     PREF_READ_ERROR_MAX_ENUM
   };
 
   class ReadErrorDelegate {
    public:
     virtual ~ReadErrorDelegate() {}
 
     virtual void OnError(PrefReadError error) = 0;
   };
 
-  // Equivalent to PrefStore::GetValue but returns a mutable value.
-  virtual bool GetMutableValue(const std::string& key,
-                               base::Value** result) = 0;
-
-  // Triggers a value changed notification. This function needs to be called
-  // if one retrieves a list or dictionary with GetMutableValue and change its
-  // value. SetValue takes care of notifications itself. Note that
-  // ReportValueChanged will trigger notifications even if nothing has changed.
-  virtual void ReportValueChanged(const std::string& key) = 0;
-
   // Same as SetValue, but doesn't generate notifications. This is used by
   // PrefService::GetMutableUserPref() in order to put empty entries
   // into the user pref store. Using SetValue is not an option since existing
   // tests rely on the number of notifications generated.
   virtual void SetValueSilently(const std::string& key, base::Value* value) = 0;

[battre, 2014/06/13 09:16:00]

What do you think of moving this function as well? Then PersistentPrefStore
contains only logic related to persistence.

[gab, 2014/06/13 14:42:34]

SGTM.

 
   // Whether the store is in a pseudo-read-only mode where changes are not
   // actually persisted to disk.  This happens in some cases when there are
   // read errors during startup.
   virtual bool ReadOnly() const = 0;
 
   // Gets the read error. Only valid if IsInitializationComplete() returns true.
   virtual PrefReadError GetReadError() const = 0;
 
   // Reads the preferences from disk. Notifies observers via
   // "PrefStore::OnInitializationCompleted" when done.
   virtual PrefReadError ReadPrefs() = 0;
 
   // Reads the preferences from disk asynchronously. Notifies observers via
   // "PrefStore::OnInitializationCompleted" when done. Also it fires
   // |error_delegate| if it is not NULL and reading error has occurred.
   // Owns |error_delegate|.
   virtual void ReadPrefsAsync(ReadErrorDelegate* error_delegate) = 0;
 
   // Lands any pending writes to disk.
   virtual void CommitPendingWrite() = 0;
 
  protected:
   virtual ~PersistentPrefStore() {}
 };
 
 #endif  // BASE_PREFS_PERSISTENT_PREF_STORE_H_