Issue 331413003: Slight refactor of search result handling in ContentsView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331413003: Slight refactor of search result handling in ContentsView. (Closed)

Created:
6 years, 6 months ago by calamity

Modified:
6 years, 6 months ago

Reviewers:
Matt Giuca

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Slight refactor of search result handling in ContentsView. This CL is a small refactor of ContentsView::ShowSearchResults() which avoids resetting the start page before showing the search results in the experimental app list. BUG=349727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278024

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
	M	ui/app_list/views/contents_view.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	ui/app_list/views/contents_view.cc	View		4 chunks	+15 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/331413003/20001

6 years, 6 months ago (2014-06-18 04:14:19 UTC) #4

Message was sent while issue was closed.

Change committed as 278024

Expand Messages | Collapse Messages