Add recurselist DEPS var setting.

Add recurselist DEPS var setting.

Previously, recursion overrides were only available by setting
a numeric 'depth' value in a DEPS file.  This meant that it
was not possible to control recursion per-dependency entry.

This change adds a recurselist variable with a list structure.
If a named dependency is present in the list, then gclient will
recurse into that dependency's DEPS.

As part of this change, I move the recursion controls off of
DependencySetting and onto Dependency.  The new setup of being
based on Dependency allows access to the dependency's name.

The controls are only called from Dependency instances.  They
have always needed access to self.parent (in the Dependency
context), so this should be more correct than the previous setup.

BUG=390246
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280690

[Dirk Pranke, 2014-06-30 20:02:41]

basically lgtm, just a couple of nits. 

The sooner I can switch to this for Blink, the better :).

https://codereview.chromium.org/331373009/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/331373009/diff/1/gclient.py#newcode315
gclient.py:315: # 'no recursion' setting on a dep-by-dep basis.  It will
deprecate
nit: 'deprecate' -> 'replace' ?

https://codereview.chromium.org/331373009/diff/1/gclient.py#newcode360
gclient.py:360: """Returns True if recursion_override is ever specified."""
returns False, not True, right?

[cmp, 2014-06-30 20:04:47]

https://codereview.chromium.org/331373009/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/331373009/diff/1/gclient.py#newcode315
gclient.py:315: # 'no recursion' setting on a dep-by-dep basis.  It will
deprecate
On 2014/06/30 20:02:41, Dirk Pranke wrote:
> nit: 'deprecate' -> 'replace' ?

Will change to replace.

https://codereview.chromium.org/331373009/diff/1/gclient.py#newcode360
gclient.py:360: """Returns True if recursion_override is ever specified."""
On 2014/06/30 20:02:41, Dirk Pranke wrote:
> returns False, not True, right?

Thanks, comment was from an earlier version with another method.  Will fix.

[cmp, 2014-06-30 20:07:01]

Updated comments.

[cmp, 2014-06-30 23:06:13]

+aneesh, today's trooper

Landing now.  Though I verified locally this shouldn't cause problems, please
revert if this causes any difficulty.

[cmp, 2014-06-30 23:06:16]

The CQ bit was checked by cmp@chromium.org

[commit-bot: I haz the power, 2014-06-30 23:06:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmp@chromium.org/331373009/40001

[commit-bot: I haz the power, 2014-06-30 23:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-30 23:08:08]

Presubmit check for 331373009-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   2526 --:--:-- --:--:-- --:--:--  2566
TESTING: Base URL contains branch name
TESTING: git-cl push ok

=======
'git cl push' has been renamed to 'git cl land'.
Currently they are treated as synonyms, but 'git cl push' will stop
working after 2014/07/01.
=======

Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:10000/5629499534213120
Closing issue (you may be prompted for your codereview password)...
Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2659, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2645, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2092, in CMDpush
    return CMDland(parser, args)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2071, in CMDland
    return SendUpstream(parser, args, 'push')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2029, in SendUpstream
    cl.CloseIssue()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 840, in CloseIssue
    return self.RpcServer().close_issue(self.GetIssue())
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 86, in close_issue
    self.post("/%d/close" % issue, [('xsrf_token', self.xsrf_token())])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 390, in post
    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/rietveld.py",
line 416, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/third_party/upload.py",
line 464, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 403: Forbidden
FAILURE: git-cl push ok


Presubmit checks took 95.6s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[cmp, 2014-06-30 23:11:11]

The CQ bit was checked by cmp@chromium.org

[commit-bot: I haz the power, 2014-06-30 23:11:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmp@chromium.org/331373009/40001

[commit-bot: I haz the power, 2014-06-30 23:14:37]

Change committed as 280690

[iannucci, 2014-06-30 23:37:05]

lgtm w/ nit

https://codereview.chromium.org/331373009/diff/40001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/331373009/diff/40001/gclient.py#newcode584
gclient.py:584: self.recurselist = local_scope.get('recurselist', None)
nit: I would have preferred recurselist actually be a set()