Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp - Issue 331373002: Split bindings/v8/custom into core and modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

Issue 331373002: Split bindings/v8/custom into core and modules. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/v8/custom/V8DeviceOrientationEventCustom.cpp ('k') | Source/bindings/modules/v8/custom/V8SQLTransactionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

diff --git a/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp b/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

similarity index 87%

rename from Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

rename to Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

index a6fed4417591f1fae65816203dbb162b8e92889b..8233f8c26650a0f1ee4009a393eb370eaa202d9a 100644

--- a/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

+++ b/Source/bindings/modules/v8/custom/V8SQLResultSetRowListCustom.cpp

@@ -70,18 +70,18 @@ void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::

for (unsigned i = 0; i < numColumns; ++i) {

const SQLValue& sqlValue = rowList->values()[valuesIndex + i];

v8::Handle<v8::Value> value;

- switch(sqlValue.type()) {

- case SQLValue::StringValue:

- value = v8String(info.GetIsolate(), sqlValue.string());

- break;

- case SQLValue::NullValue:

- value = v8::Null(info.GetIsolate());

- break;

- case SQLValue::NumberValue:

- value = v8::Number::New(info.GetIsolate(), sqlValue.number());

- break;

- default:

- ASSERT_NOT_REACHED();

+ switch (sqlValue.type()) {

+ case SQLValue::StringValue:

+ value = v8String(info.GetIsolate(), sqlValue.string());

+ break;

+ case SQLValue::NullValue:

+ value = v8::Null(info.GetIsolate());

+ break;

+ case SQLValue::NumberValue:

+ value = v8::Number::New(info.GetIsolate(), sqlValue.number());

+ break;

+ default:

+ ASSERT_NOT_REACHED();

}

item->Set(v8String(info.GetIsolate(), rowList->columnNames()[i]), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));