Source/bindings/modules/v8/v8.gypi - Issue 331373002: Split bindings/v8/custom into core and modules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/modules/v8/v8.gypi

Issue 331373002: Split bindings/v8/custom into core and modules. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'includes': [	6 'includes': [

7 'v8/v8.gypi',	7 'custom/custom.gypi',

8 ],	8 ],

9 'variables': {	9 'variables': {

10 'bindings_dir': '.',	10 'bindings_modules_v8_dir': '.',
	Nils Barth (inactive) 2014/06/24 03:14:02 This isn't being used, is it? Can you remove it? This isn't being used, is it? Can you remove it? tasak 2014/06/24 10:55:45 Done. Show quoted text On 2014/06/24 03:14:02, Nils Barth wrote: > This isn't being used, is it? > Can you remove it? Done.
11 'bindings_unittest_files': [	11 'bindings_modules_v8_files': [
	Nils Barth (inactive) 2014/06/24 03:14:02 You're not using this variable, but you should (in You're not using this variable, but you should (in Source/modules/modules.gyp) tasak 2014/06/24 10:55:45 I see. Done. Show quoted text On 2014/06/24 03:14:02, Nils Barth wrote: > You're not using this variable, but you should > (in Source/modules/modules.gyp) I see. Done.
12 '<@(bindings_v8_unittest_files)',	12 '<@(bindings_modules_v8_custom_files)',

13 ],	13 ],

14 },	14 },

15 }	15 }

OLD	NEW