Source/bindings/modules/v8/custom/custom.gypi - Issue 331373002: Split bindings/v8/custom into core and modules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/modules/v8/custom/custom.gypi

Issue 331373002: Split bindings/v8/custom into core and modules. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated bindings.gni Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'variables': {

	7 'bindings_v8_modules_custom_dir': '.',
	Nils Barth (inactive) 2014/06/17 06:43:57 You're not using this variable, so there's no need You're not using this variable, so there's no need for it. Currently bindings_v8_custom_dir is used in core/core.gyp and core/BUILD.gn as an include_dir, but this is no longer necessary (since includes of v8/custom are qualified correctly), so I'm removing it in another CL: core build: Remove unnecessary include_dirs (bindings cruft) https://codereview.chromium.org/340473002/ tasak 2014/06/24 02:43:41 Done. Show quoted text On 2014/06/17 06:43:57, Nils Barth wrote: > You're not using this variable, so there's no need for it. > Currently bindings_v8_custom_dir is used in core/core.gyp and core/BUILD.gn > as an include_dir, but this is no longer necessary > (since includes of v8/custom are qualified correctly), > so I'm removing it in another CL: > core build: Remove unnecessary include_dirs (bindings cruft) > https://codereview.chromium.org/340473002/ Done.
	8 'bindings_v8_modules_custom_files': [
	Nils Barth (inactive) 2014/06/17 06:43:57 v8 and modules are backwards; should be (matching v8 and modules are backwards; should be (matching dir order): 'bindings_modules_v8_custom_files': ... tasak 2014/06/24 02:43:41 I see. Done. Show quoted text On 2014/06/17 06:43:57, Nils Barth wrote: > v8 and modules are backwards; should be (matching dir order): > 'bindings_modules_v8_custom_files': ... I see. Done.
	9 'V8AudioNodeCustom.cpp',

	10 'V8DeviceMotionEventCustom.cpp',

	11 'V8DeviceOrientationEventCustom.cpp',

	12 'V8GeolocationCustom.cpp',

	13 'V8SubtleCryptoCustom.cpp',

	14 ],

	15 },

	16 }

OLD	NEW