Source/bindings/core/v8/custom/V8CustomSQLStatementErrorCallback.cpp - Issue 331373002: Split bindings/v8/custom into core and modules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/core/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Issue 331373002: Split bindings/v8/custom into core and modules. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved.	2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 // FIXME: This comment doesn't make much sense given what the code is actual ly doing.	73 // FIXME: This comment doesn't make much sense given what the code is actual ly doing.

74 //	74 //

75 // Step 6: If the error callback returns false, then move on to the next	75 // Step 6: If the error callback returns false, then move on to the next

76 // statement, if any, or onto the next overall step otherwise. Otherwise,	76 // statement, if any, or onto the next overall step otherwise. Otherwise,

77 // the error callback did not return false, or there was no error callback.	77 // the error callback did not return false, or there was no error callback.

78 // Jump to the last step in the overall steps.	78 // Jump to the last step in the overall steps.

79 return exceptionCatcher.HasCaught() \|\| (!result.IsEmpty() && result->Boolean Value());	79 return exceptionCatcher.HasCaught() \|\| (!result.IsEmpty() && result->Boolean Value());

80 }	80 }

81	81

82 } // namespace WebCore	82 } // namespace WebCore

OLD	NEW