Fix the crash when swap the WebContents with power save blocker.

Fix the crash when swap the WebContents with power save blocker.

BUG=383939
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282904

[Yaron, 2014-06-30 23:45:03]

https://codereview.chromium.org/331353008/diff/1/content/browser/android/cont...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/331353008/diff/1/content/browser/android/cont...
content/browser/android/content_view_core_impl.cc:281:
static_cast<WebContentsViewAndroid*>(
Ok, the only other consideration is that the WebContent's view is |this|. Are we
sure that's the case? Can this fire asynchronously as part of any swap, whereby
this happens after we've already updated the pointer elsewhere?

Put another way: InitWebContents below sets CVC for the newly created one. Are
you certain we wouldn't be unsetting it?

[michaelbai, 2014-07-01 01:10:40]

https://codereview.chromium.org/331353008/diff/1/content/browser/android/cont...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/331353008/diff/1/content/browser/android/cont...
content/browser/android/content_view_core_impl.cc:281:
static_cast<WebContentsViewAndroid*>(
How this could happen? from current code path, we can not swap the
ContentViewCore.

Also, the DCHECK in line 273 implies this.

On 2014/06/30 23:45:03, Yaron wrote:
> Ok, the only other consideration is that the WebContent's view is |this|. Are
we
> sure that's the case? Can this fire asynchronously as part of any swap,
whereby
> this happens after we've already updated the pointer elsewhere?
> 
> Put another way: InitWebContents below sets CVC for the newly created one. Are
> you certain we wouldn't be unsetting it?

[michaelbai, 2014-07-11 20:57:44]

On 2014/07/01 01:10:40, michaelbai wrote:
>
https://codereview.chromium.org/331353008/diff/1/content/browser/android/cont...
> File content/browser/android/content_view_core_impl.cc (right):
> 
>
https://codereview.chromium.org/331353008/diff/1/content/browser/android/cont...
> content/browser/android/content_view_core_impl.cc:281:
> static_cast<WebContentsViewAndroid*>(
> How this could happen? from current code path, we can not swap the
> ContentViewCore.
> 
> Also, the DCHECK in line 273 implies this.
> 
> On 2014/06/30 23:45:03, Yaron wrote:
> > Ok, the only other consideration is that the WebContent's view is |this|.
Are
> we
> > sure that's the case? Can this fire asynchronously as part of any swap,
> whereby
> > this happens after we've already updated the pointer elsewhere?
> > 
> > Put another way: InitWebContents below sets CVC for the newly created one.
Are
> > you certain we wouldn't be unsetting it?

ping

[Yaron, 2014-07-11 22:47:15]

lgtm

[michaelbai, 2014-07-14 00:58:44]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-07-14 00:59:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelbai@chromium.org/331353008/20001

[commit-bot: I haz the power, 2014-07-14 06:38:54]

Change committed as 282904