Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 331353002: Address views session crashed bubble style nits. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
yao, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Address views session crashed bubble style nits. Use the built-in bubble title and close button views. Use the bubble's title insets for the other views. Use BookmarkSyncPromoView colors for the UMA promo. Use views layout constants for the spacing values. Use default label/checkbox/bubble colors, not hard-coded. (black/off-white + supports inversion for accessibility) Fix the UMA promo separator line (wasn't fully extended). Inline some BrowserRemovalObserver function implementations. Other misc. code cleanup. See before/after pics on the bug. BUG=384123 TEST=Session crashes bubble looks good, works well. R=yiyaoliu@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278228

Patch Set 1 #

Patch Set 2 : Fix right inset; remove debugging aids. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -111 lines) Patch
M chrome/browser/ui/views/session_crashed_bubble_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 12 chunks +60 lines, -108 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Please take a look and see the pics on the bug; thanks! This CL makes ...
6 years, 6 months ago (2014-06-18 01:51:45 UTC) #1
yao
lgtm Hi Mike, Thanks a lot for doing this. There's many thing I didn't know/realize ...
6 years, 6 months ago (2014-06-18 14:44:27 UTC) #2
msw
On 2014/06/18 14:44:27, yao wrote: > Hi Mike, > > Thanks a lot for doing ...
6 years, 6 months ago (2014-06-18 15:49:49 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-18 17:14:09 UTC) #4
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-18 17:33:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/331353002/40001
6 years, 6 months ago (2014-06-18 17:35:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 01:33:49 UTC) #7
Message was sent while issue was closed.
Change committed as 278228

Powered by Google App Engine
This is Rietveld 408576698