Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 331343003: Remove Net.URLRequest_SetReferrer_IsEmptyOrValid histogram. (Closed)

Created:
6 years, 6 months ago by Alexei Svitkine (slow)
Modified:
6 years, 6 months ago
Reviewers:
cbentzel, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove Net.URLRequest_SetReferrer_IsEmptyOrValid histogram. According to internal stats, this was the top 5 histogram that's taking up space in UMA and it was never documented in histograms.xml, which means no one has ever looked at its data. Delete it so that it stop taking resources without providing value. Document it in histograms.xml so that previous data can still be viewed on the dashboard, if needed. BUG=387734 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M net/url_request/url_request.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
6 years, 6 months ago (2014-06-23 15:41:49 UTC) #1
cbentzel
+mef: Do you remember why this was put in? LGTM
6 years, 6 months ago (2014-06-24 13:11:22 UTC) #2
mef
On 2014/06/24 13:11:22, cbentzel wrote: > +mef: Do you remember why this was put in? ...
6 years, 6 months ago (2014-06-24 14:05:17 UTC) #3
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 6 months ago (2014-06-25 02:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/331343003/1
6 years, 6 months ago (2014-06-25 02:06:37 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 06:43:13 UTC) #6
Message was sent while issue was closed.
Change committed as 279639

Powered by Google App Engine
This is Rietveld 408576698