Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 331333002: [linux] Put action button on the right in chrome://settings dialogs. (Closed)

Created:
6 years, 6 months ago by Evan Stade
Modified:
6 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[linux] Put action button on the right in chrome://settings dialogs. this regressed when we switched to the aura build for linux. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/options/options_page.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
6 years, 6 months ago (2014-06-17 02:03:05 UTC) #1
Dan Beam
lgtm fwiw
6 years, 6 months ago (2014-06-17 02:19:57 UTC) #2
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-17 17:19:26 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-06-17 21:10:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/331333002/1
6 years, 6 months ago (2014-06-17 21:13:50 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:50:02 UTC) #6
Message was sent while issue was closed.
Change committed as 277996

Powered by Google App Engine
This is Rietveld 408576698