app-shell: Introduce a ShellRendererMainDelegate.

athena/main/athena_main.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/app/shell_main_delegate.h"
 #include "apps/shell/browser/shell_browser_main_delegate.h"
 #include "apps/shell/browser/shell_desktop_controller.h"
 #include "apps/shell/browser/shell_extension_system.h"
+#include "apps/shell/renderer/shell_renderer_main_delegate.h"
 #include "athena/content/public/content_activity_factory.h"
 #include "athena/content/public/content_app_model_builder.h"
 #include "athena/home/public/home_card.h"
 #include "athena/main/athena_launcher.h"
 #include "athena/main/placeholder.h"
 #include "athena/main/url_search_provider.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "content/public/app/content_main.h"
 #include "ui/aura/window_tree_host.h"
@@ skipping 33 matching lines @@
   virtual apps::ShellDesktopController* CreateDesktopController() OVERRIDE {
     // TODO(mukai): create Athena's own ShellDesktopController subclass so that
     // it can initialize its own window manager logic.
     return new apps::ShellDesktopController();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AthenaBrowserMainDelegate);
 };
 
+class AthenaRendererMainDelegate : public apps::ShellRendererMainDelegate {
+ public:
+  virtual ~AthenaRendererMainDelegate() {}
+
+ private:
+  // apps::ShellRendererMainDelegate:
+  virtual void OnThreadStarted(content::RenderThread* thread) OVERRIDE {}
+
+  virtual void OnViewCreated(content::RenderView* render_view) OVERRIDE {}
+};

[James Cook, 2014/06/17 17:40:22]

DISALLOW_COPY_AND_ASSIGN?

[sadrul, 2014/06/17 20:37:39]

Done.

+
 class AthenaMainDelegate : public apps::ShellMainDelegate {
  public:
   AthenaMainDelegate() {}
   virtual ~AthenaMainDelegate() {}
 
  private:
   // apps::ShellMainDelegate:
   virtual apps::ShellBrowserMainDelegate* CreateShellBrowserMainDelegate()
       OVERRIDE {
     return new AthenaBrowserMainDelegate();
   }
 
+  virtual apps::ShellRendererMainDelegate* CreateShellRendererMainDelegate()
+      OVERRIDE {
+    return new AthenaRendererMainDelegate();

[James Cook, 2014/06/17 17:40:22]

Doesn't this leak?

[sadrul, 2014/06/17 20:37:39]

It indeed does. I have clarified the ownership of this (see previous comment)

+  }
+
   DISALLOW_COPY_AND_ASSIGN(AthenaMainDelegate);
 };
 
 int main(int argc, const char** argv) {
   AthenaMainDelegate delegate;
   content::ContentMainParams params(&delegate);
 
   params.argc = argc;
   params.argv = argv;
 
   return content::ContentMain(params);
 }