Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 331313011: Switch URL and URLUtils interfaces over to use ScalarValueString. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Switch URL and URLUtils interfaces over to use ScalarValueString. R=arv@chromium.org,jsbell@chromium.org BUG=303152 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176782

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tidy new url-constructor test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -27 lines) Patch
M LayoutTests/fast/domurl/url-constructor.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/domurl/url-hash.html View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/domurl/url-host.html View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/domurl/url-pathname.html View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/dom/URL.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/URLUtils.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/dom/URLUtilsReadOnly.idl View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-23 09:45:17 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/331313011/diff/1/LayoutTests/fast/domurl/url-constructor.html File LayoutTests/fast/domurl/url-constructor.html (right): https://codereview.chromium.org/331313011/diff/1/LayoutTests/fast/domurl/url-constructor.html#newcode17 LayoutTests/fast/domurl/url-constructor.html:17: var encodedReplacementCharacter = encodeURIComponent('\ufffd'); Since this is only ...
6 years, 6 months ago (2014-06-23 16:12:02 UTC) #2
jsbell
lgtm
6 years, 6 months ago (2014-06-23 16:35:58 UTC) #3
sof
https://codereview.chromium.org/331313011/diff/1/LayoutTests/fast/domurl/url-constructor.html File LayoutTests/fast/domurl/url-constructor.html (right): https://codereview.chromium.org/331313011/diff/1/LayoutTests/fast/domurl/url-constructor.html#newcode17 LayoutTests/fast/domurl/url-constructor.html:17: var encodedReplacementCharacter = encodeURIComponent('\ufffd'); On 2014/06/23 16:12:01, arv wrote: ...
6 years, 6 months ago (2014-06-23 19:02:48 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-23 19:02:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/331313011/20001
6 years, 6 months ago (2014-06-23 19:03:38 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 20:05:54 UTC) #7
Message was sent while issue was closed.
Change committed as 176782

Powered by Google App Engine
This is Rietveld 408576698