Reset GPUVideoEncodeAccelerator::encoder_ when destroying

Reset GPUVideoEncodeAccelerator::encoder_ when destroying

I broke this in https://src.chromium.org/viewvc/chrome?revision=273860.
The DCHECK is to make sure that the proper destruction sequence is
happening. Reset encoder_ so the DCHECK is valid again.

Already fixed for the decoder here:
https://src.chromium.org/viewvc/chrome?view=rev&revision=275513

BUG=386170
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278132

[xhwang, 2014-06-18 16:26:04]

lgtm

[siping.tao_gmail.com, 2014-06-18 16:41:58]

Interesting, after this fix, the crash stack moves to

signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
Stack frame #00  pc 000220dc  /system/lib/libc.so (tgkill+12)
Stack frame #01  pc 00013131  /system/lib/libc.so (pthread_kill+48)
Stack frame #02  pc 00013345  /system/lib/libc.so (raise+10)
Stack frame #03  pc 0001207b  /system/lib/libc.so
Stack frame #04  pc 00021990  /system/lib/libc.so (abort+4)
Stack frame #05  pc 0022b8a9
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
DebugBreak at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../base/debug/debugger_posix.cc:217
Stack frame #06  pc 002416af
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
logging::LogMessage::~LogMessage() at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../base/logging.cc:644
Stack frame #07  pc 01b756a3
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
content::RTCVideoEncoder::SetChannelParameters(unsigned int, int) at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../content/renderer/media/rtc_video_encoder.cc:620
(discriminator 1)
Stack frame #08  pc 01c08cfb
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::VCMGenericEncoder::SetChannelParameters(int, int) at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/video_coding/main/source/generic_encoder.cc:108
Stack frame #09  pc 01c10ed9
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::vcm::VideoSender::SetChannelParameters(unsigned int, unsigned char,
unsigned int) at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/video_coding/main/source/video_sender.cc:257
Stack frame #10  pc 01cd28cb
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::ViEEncoder::OnNetworkChanged(unsigned int, unsigned char, unsigned
int) at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/video_engine/vie_encoder.cc:844
Stack frame #11  pc 01cab2f9
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::BitrateControllerImpl::NormalRateAllocation(unsigned int, unsigned
char, unsigned int, unsigned int) at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc:316
Stack frame #12  pc 01cab369
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::BitrateControllerImpl::OnNetworkChanged(unsigned int, unsigned
char, unsigned int) at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc:282
Stack frame #13  pc 01cab3df
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::BitrateControllerImpl::MaybeTriggerOnNetworkChanged() at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc:263
Stack frame #14  pc 01cab465
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::BitrateControllerImpl::Process() at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc:227
Stack frame #15  pc 01be3051
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::ProcessThreadImpl::Process() at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/modules/utility/source/process_thread_impl.cc:165
Stack frame #16  pc 01a35655
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
webrtc::ThreadPosix::Run() at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/system_wrappers/source/thread_posix.cc:332
Stack frame #17  pc 01a35689
 /data/app-lib/org.chromium.chrome.shell-2/libchromeshell.so: Routine
StartThread at
/local/mnt/workspace/chromium_latest/src/out/Debug/../../third_party/webrtc/system_wrappers/source/thread_posix.cc:95
Stack frame #18  pc 0000d220  /system/lib/libc.so (__thread_entry+72)
Stack frame #19  pc 0000d3b8  /system/lib/libc.so (pthread_create+240)


On Wed, Jun 18, 2014 at 9:26 AM, <xhwang@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/331293006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmichael (off chromium), 2014-06-18 16:47:03]

maybe xhwang or somebody on media can help with that crash? It looks unrelated
to me; like SetChannelParameters is being called on the wrong thread.

[dmichael (off chromium), 2014-06-18 16:47:07]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-06-18 16:48:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmichael@chromium.org/331293006/1

[xhwang, 2014-06-18 16:52:17]

hshi/wuchengli: Could you please take a look at the crash stack
siping.tao_gmail.com mentioned above?

[commit-bot: I haz the power, 2014-06-18 18:40:19]

Change committed as 278132

[wuchengli, 2014-06-19 09:22:11]

On 2014/06/18 16:52:17, xhwang wrote:
> hshi/wuchengli: Could you please take a look at the crash stack
> http://siping.tao_gmail.com mentioned above?
That is http://crbug.com/350111. I'm working on it.

[siping.tao_gmail.com, 2014-06-19 22:41:48]

By the way, I just checked LKGR, same crash stack.


On Thu, Jun 19, 2014 at 2:22 AM, <wuchengli@chromium.org> wrote:

> On 2014/06/18 16:52:17, xhwang wrote:
>
>> hshi/wuchengli: Could you please take a look at the crash stack
>> http://siping.tao_gmail.com mentioned above?
>>
> That is http://crbug.com/350111. I'm working on it.
>
> https://codereview.chromium.org/331293006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[siping.tao_gmail.com, 2014-06-24 16:15:24]

Any update about this crash? I cannot access http://crbug.com/350111, so I
have no idea whether this has been fixed already.


On Thu, Jun 19, 2014 at 3:41 PM, tao siping <siping.tao@gmail.com> wrote:

> By the way, I just checked LKGR, same crash stack.
>
>
> On Thu, Jun 19, 2014 at 2:22 AM, <wuchengli@chromium.org> wrote:
>
>> On 2014/06/18 16:52:17, xhwang wrote:
>>
>>> hshi/wuchengli: Could you please take a look at the crash stack
>>> http://siping.tao_gmail.com mentioned above?
>>>
>> That is http://crbug.com/350111. I'm working on it.
>>
>> https://codereview.chromium.org/331293006/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[wuchengli, 2014-06-25 03:53:09]

The fix is being submitted. https://codereview.chromium.org/347073002/


On Wed, Jun 25, 2014 at 12:15 AM, tao siping <siping.tao@gmail.com> wrote:

> Any update about this crash? I cannot access http://crbug.com/350111, so
> I have no idea whether this has been fixed already.
>
>
> On Thu, Jun 19, 2014 at 3:41 PM, tao siping <siping.tao@gmail.com> wrote:
>
>> By the way, I just checked LKGR, same crash stack.
>>
>>
>> On Thu, Jun 19, 2014 at 2:22 AM, <wuchengli@chromium.org> wrote:
>>
>>> On 2014/06/18 16:52:17, xhwang wrote:
>>>
>>>> hshi/wuchengli: Could you please take a look at the crash stack
>>>> http://siping.tao_gmail.com mentioned above?
>>>>
>>> That is http://crbug.com/350111. I'm working on it.
>>>
>>> https://codereview.chromium.org/331293006/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.