Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 331283004: Oilpan: Trace MediaQueryMacher::m_document. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: Trace MediaQueryMacher::m_document. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176275

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/css/MediaQueryMatcher.h View 1 chunk +1 line, -1 line 2 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-17 01:09:19 UTC) #1
haraken
LGTM https://codereview.chromium.org/331283004/diff/1/Source/core/css/MediaQueryMatcher.h File Source/core/css/MediaQueryMatcher.h (right): https://codereview.chromium.org/331283004/diff/1/Source/core/css/MediaQueryMatcher.h#newcode74 Source/core/css/MediaQueryMatcher.h:74: MediaQueryMatcher(Document*); Add explicit.
6 years, 6 months ago (2014-06-17 01:13:07 UTC) #2
tkent
https://codereview.chromium.org/331283004/diff/1/Source/core/css/MediaQueryMatcher.h File Source/core/css/MediaQueryMatcher.h (right): https://codereview.chromium.org/331283004/diff/1/Source/core/css/MediaQueryMatcher.h#newcode74 Source/core/css/MediaQueryMatcher.h:74: MediaQueryMatcher(Document*); On 2014/06/17 01:13:07, haraken wrote: > > Add ...
6 years, 6 months ago (2014-06-17 01:43:02 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-17 01:43:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/331283004/1
6 years, 6 months ago (2014-06-17 01:44:07 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 03:24:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 176275

Powered by Google App Engine
This is Rietveld 408576698