Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 331283002: stop calling deprecated setConfig (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

stop calling deprecated setConfig BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277985

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase + typo fixes #

Patch Set 3 : rebase + android typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -73 lines) Patch
M skia/ext/analysis_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 2 3 chunks +4 lines, -8 lines 0 comments Download
M skia/ext/convolver_unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M skia/ext/image_operations.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M skia/ext/image_operations_bench.cc View 1 chunk +1 line, -3 lines 0 comments Download
M skia/ext/image_operations_unittest.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M skia/ext/pixel_ref_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 2 chunks +3 lines, -10 lines 0 comments Download
M skia/ext/skia_utils_mac_unittest.mm View 2 chunks +6 lines, -8 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 1 chunk +5 lines, -9 lines 0 comments Download
M skia/ext/vector_platform_device_skia.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
reed1
6 years, 6 months ago (2014-06-16 20:22:19 UTC) #1
f(malita)
lgtm https://codereview.chromium.org/331283002/diff/1/skia/ext/vector_platform_device_emf_win.cc File skia/ext/vector_platform_device_emf_win.cc (right): https://codereview.chromium.org/331283002/diff/1/skia/ext/vector_platform_device_emf_win.cc#newcode93 skia/ext/vector_platform_device_emf_win.cc:93: bitmap.setInfo(SkImageInfo::MakeEmpty(width, height)); This actually looks like it's fixing ...
6 years, 6 months ago (2014-06-16 21:00:46 UTC) #2
reed1
https://codereview.chromium.org/331283002/diff/1/skia/ext/vector_platform_device_emf_win.cc File skia/ext/vector_platform_device_emf_win.cc (right): https://codereview.chromium.org/331283002/diff/1/skia/ext/vector_platform_device_emf_win.cc#newcode93 skia/ext/vector_platform_device_emf_win.cc:93: bitmap.setInfo(SkImageInfo::MakeEmpty(width, height)); On 2014/06/16 21:00:45, Florin Malita wrote: > ...
6 years, 6 months ago (2014-06-16 21:19:04 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-16 21:19:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/331283002/1
6 years, 6 months ago (2014-06-16 21:22:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 02:51:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/152647) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/196316) linux_chromium_gn_rel ...
6 years, 6 months ago (2014-06-17 02:51:22 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-17 17:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/331283002/20001
6 years, 6 months ago (2014-06-17 17:58:20 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 20:59:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/152961) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/196692)
6 years, 6 months ago (2014-06-17 20:59:28 UTC) #11
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-17 21:02:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/331283002/40001
6 years, 6 months ago (2014-06-17 21:03:25 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:33:28 UTC) #14
Message was sent while issue was closed. 
Change committed as 277985

Powered by Google App Engine
This is Rietveld 408576698