Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: sdk/lib/_internal/pub/test/test_pub.dart

Issue 331263002: Improve parallelism when loading transformer plugins. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/test_pub.dart
diff --git a/sdk/lib/_internal/pub/test/test_pub.dart b/sdk/lib/_internal/pub/test/test_pub.dart
index 2380ed31d10e97c22177401a1f972b7de5a88863..f99305fa1a47545fff19f3a798f26275a64dd249 100644
--- a/sdk/lib/_internal/pub/test/test_pub.dart
+++ b/sdk/lib/_internal/pub/test/test_pub.dart
@@ -284,6 +284,11 @@ String yaml(value) => JSON.encode(value);
String get sandboxDir => _sandboxDir;
String _sandboxDir;
+/// The path to the Dart repo's packages.
+final String pkgPath = path.absolute(path.join(
+ path.dirname(Platform.executable),
+ '..', '..', '..', '..', 'pkg'));
+
/// The path of the package cache directory used for tests. Relative to the
/// sandbox directory.
final String cachePath = "cache";
@@ -674,10 +679,6 @@ void createLockFile(String package, {Iterable<String> sandbox,
}
if (pkg != null) {
- var pkgDir = path.absolute(path.join(
- path.dirname(Platform.executable),
- '..', '..', '..', '..', 'pkg'));
-
_addPackage(String package) {
if (dependencies.containsKey(package)) return;
@@ -690,7 +691,7 @@ void createLockFile(String package, {Iterable<String> sandbox,
}
packagePath = _barbackDir;
} else {
- packagePath = path.join(pkgDir, package);
+ packagePath = path.join(pkgPath, package);
}
dependencies[package] = packagePath;
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/utils.dart ('k') | sdk/lib/_internal/pub/test/transformer/detects_a_transformer_cycle_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698