Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 331243002: Makes IViewManager::DeleteNode take the server_change_id (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Makes IViewManager::DeleteNode take the server_change_id Clearer this way, especially since a deletion may entail a hierarchy change. BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277847

Patch Set 1 #

Patch Set 2 : resolve merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 7 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sky
6 years, 6 months ago (2014-06-16 17:30:04 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-16 17:32:15 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-16 17:36:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/331243002/1
6 years, 6 months ago (2014-06-16 17:38:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 03:24:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/21431)
6 years, 6 months ago (2014-06-17 03:24:41 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-17 15:00:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/331243002/20001
6 years, 6 months ago (2014-06-17 15:02:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 19:23:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/163193)
6 years, 6 months ago (2014-06-17 19:23:43 UTC) #10
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-17 19:58:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/331243002/20001
6 years, 6 months ago (2014-06-17 20:01:35 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 20:13:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/163193)
6 years, 6 months ago (2014-06-17 20:13:48 UTC) #14
sky
6 years, 6 months ago (2014-06-17 20:25:15 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 manually as r277847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698