Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 331223004: Move const string declaration into #ifdef USE_GIO block (Closed)

Created:
6 years, 6 months ago by dnicoara
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move const string declaration into #ifdef USE_GIO block The string is only used in that block, causing Clang errors when USE_GIO isn't defined. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/proxy/proxy_config_service_linux.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dnicoara
PTAL
6 years, 6 months ago (2014-06-18 16:41:03 UTC) #1
rvargas (doing something else)
lgtm
6 years, 6 months ago (2014-06-18 18:00:12 UTC) #2
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 6 months ago (2014-06-18 19:14:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/331223004/1
6 years, 6 months ago (2014-06-18 19:16:23 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 06:30:19 UTC) #5
Message was sent while issue was closed.
Change committed as 278282

Powered by Google App Engine
This is Rietveld 408576698