Issue 331223002: NavigatorContentUtilsClientImpl has own files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331223002: NavigatorContentUtilsClientImpl has own files (Closed)

Created:
6 years, 6 months ago by gyuyoung-inactive

Modified:
6 years, 6 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

NavigatorContentUtilsClientImpl has own files NavigatorContentUtilsClientImpl has been placed in ChromeClientImpl.cpp. It would be good if NavigatorContentUtilsClientImpl has own file, because new functions have been added to the NavigatorContentUtilsClientImpl. Besides more functionality will be added in future. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176286

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -41 lines)			Patch
M	Source/web/ChromeClientImpl.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/web/ChromeClientImpl.cpp	View	1 chunk	+0 lines, -26 lines	0 comments	Download
A	Source/web/NavigatorContentUtilsClientImpl.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	Source/web/NavigatorContentUtilsClientImpl.cpp	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/web.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/331223002/1

6 years, 6 months ago (2014-06-17 05:07:34 UTC) #4

Message was sent while issue was closed.

Change committed as 176286

Expand Messages | Collapse Messages