Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 331213003: Remove support for specifying page_set attribute with file_path in benchmarks. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Dave's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M tools/telemetry/telemetry/test.py View 1 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-16 17:15:40 UTC) #1
dtu
lgtm https://chromiumcodereview.appspot.com/331213003/diff/1/tools/telemetry/telemetry/test.py File tools/telemetry/telemetry/test.py (right): https://chromiumcodereview.appspot.com/331213003/diff/1/tools/telemetry/telemetry/test.py#newcode42 tools/telemetry/telemetry/test.py:42: # TODO(dtu): Remove this code path after crbug.com/362293. ...
6 years, 6 months ago (2014-06-18 21:09:31 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-19 04:05:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/331213003/20001
6 years, 6 months ago (2014-06-19 04:10:41 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 13:10:37 UTC) #5
Message was sent while issue was closed.
Change committed as 278353

Powered by Google App Engine
This is Rietveld 408576698