Source/core/rendering/compositing/CompositingLayerAssigner.h - Issue 331203003: Improve the compositing reasons when squashing fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositingLayerAssigner.h

Issue 331203003: Improve the compositing reasons when squashing fails (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/compositing/CompositingLayerAssigner.h

diff --git a/Source/core/rendering/compositing/CompositingLayerAssigner.h b/Source/core/rendering/compositing/CompositingLayerAssigner.h

index 0cfb1112fdc6e73fce5eead742a6a1f79ff65a90..ccc283d3e2048bea9c2af9d7f6ec8457aa8255e9 100644

--- a/Source/core/rendering/compositing/CompositingLayerAssigner.h

+++ b/Source/core/rendering/compositing/CompositingLayerAssigner.h

@@ -79,7 +79,7 @@ private:

void assignLayersToBackingsInternal(RenderLayer*, SquashingState&, bool& layersChanged, Vector<RenderLayer*>& layersNeedingRepaint);

void assignLayersToBackingsForReflectionLayer(RenderLayer* reflectionLayer, bool& layersChanged, Vector<RenderLayer*>& layersNeedingRepaint);

- bool canSquashIntoCurrentSquashingOwner(const RenderLayer*, const SquashingState&);

+ CompositingReasons getReasonsPreventingSquashing(const RenderLayer*, const SquashingState&);

bool squashingWouldExceedSparsityTolerance(const RenderLayer* candidate, const SquashingState&);

bool updateSquashingAssignment(RenderLayer*, SquashingState&, CompositingStateTransitionType, Vector<RenderLayer*>& layersNeedingRepaint);

bool needsOwnBacking(const RenderLayer*) const;