Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Source/core/rendering/RenderFlexibleBox.cpp

Index: Source/core/rendering/RenderFlexibleBox.cpp
diff --git a/Source/core/rendering/RenderFlexibleBox.cpp b/Source/core/rendering/RenderFlexibleBox.cpp
index 59389a119b2539aaa3178732beb510348422f3d9..559be8a28ad46b477ed5ec9d04c0a039a4888f06 100644
--- a/Source/core/rendering/RenderFlexibleBox.cpp
+++ b/Source/core/rendering/RenderFlexibleBox.cpp
@@ -1375,8 +1375,10 @@ void RenderFlexibleBox::applyStretchAlignmentToChild(RenderBox* child, LayoutUni
             // FIXME: Can avoid laying out here in some cases. See https://webkit.org/b/87905.
             if (desiredLogicalHeight != child->logicalHeight()) {
                 child->setOverrideLogicalContentHeight(desiredLogicalHeight - child->borderAndPaddingLogicalHeight());
+                child->setOverrideContainingBlockContentLogicalHeight(desiredLogicalHeight);
                 child->setLogicalHeight(0);
                 child->forceChildLayout();
+                child->clearOverrideContainingBlockContentLogicalHeight();

[tony, 2014/06/19 16:37:46]

Why do we clear the value?  If we need to relayout the grandchild, will it
relayout properly?  E.g., if we change the height of the grandchild to a
different percent value, will it be able to compute itself properly?

[harpreet.sk, 2014/06/20 14:54:32]

I clear the value because consider the case below:

<div class="flexbox" style="height:50px">
  <img id="green1" data-expected-height="25" style="max-height:50%"
src="../images/resources/green-10.png">
</div>

In this case when it enters the applyStretchAlignmentToChild first time it sets
the OverrideContainingBlockContentLogicalHeight to be 25. When it enters the
second time  and computes desired logical height it computes max-height which is
50% of OverrideContainingBlockContentLogicalHeight which we have set and which
is 25 and made the height of image equal to 12.5 which is wrong.

Since this case was failing so i thought to
clearOverideContainingBlockContentLogicalHeight.

Now i have find a better solution in which we will set
OverrideContainingBlockContentLogicalHeight equal to stretchedLogicalHeight -
child->borderAndPaddingLogicalHeight() and not desiredLogicalHeight
and so we dont need to clear the value. All cases are working fine with the new
solution.

             }
         }
     } else if (isColumnFlow() && child->style()->logicalWidth().isAuto()) {