Source/core/rendering/RenderFlexibleBox.h - Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlexibleBox.h

Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderBox.cpp ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderFlexibleBox.h

diff --git a/Source/core/rendering/RenderFlexibleBox.h b/Source/core/rendering/RenderFlexibleBox.h

index 342a6a73e6ea28e6d3b87b84b26ea93fcc1eb2cb..adf5442cf4dcff399406e09bbd97b4d81c13ffb8 100644

--- a/Source/core/rendering/RenderFlexibleBox.h

+++ b/Source/core/rendering/RenderFlexibleBox.h

@@ -147,6 +147,7 @@ private:

void resetAutoMarginsAndLogicalTopInCrossAxis(RenderBox*);

void setLogicalOverrideSize(RenderBox* child, LayoutUnit childPreferredSize);

+ void clearLogicalOverrideSize(RenderBox* child);

void prepareChildForPositionedLayout(RenderBox* child, LayoutUnit mainAxisOffset, LayoutUnit crossAxisOffset, PositionedLayoutMode);

size_t numberOfInFlowPositionedChildren(const OrderedFlexItemList&) const;

void layoutAndPlaceChildren(LayoutUnit& crossAxisOffset, const OrderedFlexItemList&, const Vector<LayoutUnit, 16>& childSizes, LayoutUnit availableFreeSpace, bool relayoutChildren, Vector<LineContext>&, bool hasInfiniteLineLength);