Source/core/rendering/RenderBox.cpp - Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New patch set based on comments in patch set 1 Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item-expected.txt ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 6245b13d9c5c65345753c31990ed1d75bb31f0cb..101de663a933e3ad248ea25d4d13d266fda50906 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -2674,8 +2674,8 @@ LayoutUnit RenderBox::computePercentageLogicalHeight(const Length& height) const

if (isHorizontalWritingMode() != cb->isHorizontalWritingMode())

availableHeight = containingBlockChild->containingBlockLogicalWidthForContent();

- else if (hasOverrideContainingBlockLogicalHeight())

- availableHeight = overrideContainingBlockContentLogicalHeight();

+ else if (cb->hasOverrideContainingBlockLogicalHeight())

+ availableHeight = cb->overrideContainingBlockContentLogicalHeight();

tony 2014/06/18 17:53:18 Why remove the previous check? Shouldn't this be

harpreet.sk 2014/06/19 12:22:38 You are right. I didn't have to remove this check.

else if (cb->isTableCell()) {

if (!skippedAutoHeightContainingBlock) {

// Table cells violate what the CSS spec says to do with heights. Basically we