Source/core/rendering/RenderBox.cpp - Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addresses changes asked in comments in patch set 5 Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index eecb1465fd5aa3fddb8b385e56e86933d904cd96..b2f0aab5bbcee0264722eb7414a679928411c188 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -2673,6 +2673,8 @@ LayoutUnit RenderBox::computePercentageLogicalHeight(const Length& height) const

availableHeight = containingBlockChild->containingBlockLogicalWidthForContent();

else if (hasOverrideContainingBlockLogicalHeight())

availableHeight = overrideContainingBlockContentLogicalHeight();

+ else if (cb->isFlexItem() && cb->hasOverrideContainingBlockLogicalHeight())

+ availableHeight = cb->overrideContainingBlockContentLogicalHeight();

else if (cb->isTableCell()) {

if (!skippedAutoHeightContainingBlock) {

// Table cells violate what the CSS spec says to do with heights. Basically we

« no previous file with comments | « Source/core/rendering/RenderBox.h ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')